Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clean shutdown #103

Closed
5 of 6 tasks
flosell opened this issue Apr 3, 2016 · 1 comment
Closed
5 of 6 tasks

Implement clean shutdown #103

flosell opened this issue Apr 3, 2016 · 1 comment

Comments

@flosell
Copy link
Owner

flosell commented Apr 3, 2016

Currently, when the LambdaCD process is stopped (e.g. through SIGTERM), LambdaCD just stops. This can cause problems:

  • Writing the build history might be interrupted, causing corrupted data
  • When starting again, builds that were running are still in this state even though they were interrupted when LambdaCD was killed

Tasks:

  • make sure no new pipelines are spawned when shutting down
  • make sure we can kill running pipelines before shutting down
  • make sure we can cleanly shut down the persistence
  • add shutdown hook that calls the above process

Optional:

flosell added a commit that referenced this issue Apr 3, 2016
flosell added a commit that referenced this issue Apr 3, 2016
…ut down even if build steps don't implement step-killing properly (#103)
flosell added a commit that referenced this issue Apr 3, 2016
flosell added a commit that referenced this issue Apr 3, 2016
@flosell
Copy link
Owner Author

flosell commented Apr 3, 2016

Basic support implemented and released in 0.8.0.

Functions exist to shut down the active parts of LambdaCD and an aggregate and configurable shutdown hook exists as well.
The same hook can also be used to dynamically stop pipelines.

If necessary, it should also be easy to build a feature that, instead of killing active pipelines, waits for them to finish (similar to wait-for-pipelines-to-complete) and only shuts down afterwards.

@flosell flosell closed this as completed Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant