fail in-parallel only after no other step is running (#68)

CHANGELOG.md

@@ -10,8 +10,10 @@ The official release will have a defined and more stable API. If you are already
   * UI: Adding feature to collapse/expand all or active steps (#59)
 * Bugs: 
   * `either` no longer aggregates to failure if only some children failed (#67)
+  * `in-parallel` no longer aggregates to failure while other children are still running (#68)
 * Breaking Changes: 
-  * `successful-when-one-successful` status aggregation only fails if all statuses are `:failure` (#64)
+  * `successful-when-one-successful` status aggregation only fails if all statuses are `:failure` (#67)
+  * `successful-when-all-successful-sequential` status aggregation doesn't fail while other steps are still running (#68)
 
 ## 0.5.7
 * Improvements:

src/clj/lambdacd/steps/status.clj

@@ -19,8 +19,8 @@
 
 (defn successful-when-all-successful [statuses]
   (cond
-    (one-in statuses :failure) :failure
     (one-in statuses :running) :running
     (one-in statuses :waiting) :waiting
+    (one-in statuses :failure) :failure
     (all    statuses :success) :success
     :else                      :unknown))

test/clj/lambdacd/steps/control_flow_test.clj

@@ -34,9 +34,16 @@
 
 (defn some-successful-step [arg & _]
   {:status :success})
+
 (defn some-failing-step [arg & _]
   {:status :failure})
 
+(defn some-step-sending-failure-but-returning-success [_ {ch :result-channel}]
+  (async/>!! ch [:status :running])
+  (async/>!! ch [:status :failure])
+  (Thread/sleep 20)
+  {:status :success})
+
 (defn some-step-sending-waiting-on-channel [_ {ch :result-channel}]
   (async/>!! ch [:status :running])
   (Thread/sleep 20)
@@ -106,6 +113,13 @@
       (is (= [[:status :running]
               [:status :waiting]
               [:status :success]] (slurp-chan result-ch)))))
+  (testing "that it doesnt immediately inherit failures on the result channel so it doesn't look like the step has failed just because a child failed"
+    (let [result-ch (async/chan 100)
+          ctx (some-ctx-with :result-channel result-ch :step-id [333])]
+      ((in-parallel some-step-sending-failure-but-returning-success some-step-sending-running-then-waiting-then-finished-on-channel) {} ctx)
+      (is (= [[:status :running]
+              [:status :waiting]
+              [:status :success]] (slurp-chan result-ch)))))
   (testing "that it kills all children if it is killed"
     (let [is-killed (atom true)
           ctx       (some-ctx-with :is-killed is-killed

test/clj/lambdacd/steps/status_test.clj

@@ -22,15 +22,14 @@
   (testing "undefined otherwise"
     (is (= :unknown (successful-when-one-successful [:foo :bar])))))
 
-
 (deftest successful-when-all-successful-test
   (testing "that that all successful steps make a successful unified view"
     (is (= :success (successful-when-all-successful [:success])))
     (is (= :success (successful-when-all-successful [:success :success]))))
-  (testing "that one failed step fails the unified view"
+  (testing "it doesnt fail as long as something is running"
     (is (= :failure (successful-when-all-successful [:failure])))
-    (is (= :failure (successful-when-all-successful [:failure :running])))
-    (is (= :failure (successful-when-all-successful [:failure :waiting])))
+    (is (= :running (successful-when-all-successful [:failure :running])))
+    (is (= :waiting (successful-when-all-successful [:failure :waiting])))
     (is (= :failure (successful-when-all-successful [:success :failure]))))
   (testing "that one waiting makes the unified view waiting when nothing's running"
     (is (= :waiting (successful-when-all-successful [:success :waiting]))))