nil in pipeline-structure breaks step-id calculation leading to mismatches in the UI

[flosell]

Steps to reproduce.

• Add a nil-value to the pipeline structure, e.g.

  (with-frontend-git
          nil
          create-some-details
          client-package
          client-publish)

• Observe that the UI now does not show output for create-some-details but it's output is visible in the next step:

Possible Reasons:

The nil value in the pipeline structure gets filtered out when creating the representation the UI uses but is not filtered when the pipeline gets executed. In the example. create-some-details would be the first child of with-frontend-git in the UI representation but the second child when it comes to calculating the step-id on execution (meaning state will also be written with these step-ids)

Where does this happen in practice?

If you want to create several pipelines from the same structure you might use conditionals that evaluate to nil if not needed in this particular pipeline:

~(when use-trigger?
     `(alias "trigger"
        wait-for-manual-trigger))

[flosell]

Released in 0.13.4