Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build dependency javasysmon 0.3.6 gone? #203

Closed
hennr opened this issue May 3, 2021 · 4 comments · Fixed by #205
Closed

build dependency javasysmon 0.3.6 gone? #203

hennr opened this issue May 3, 2021 · 4 comments · Fixed by #205

Comments

@hennr
Copy link
Contributor

hennr commented May 3, 2021

lambdacd includes this repo to resolve "com.jezhumble/javasysmon:0.3.6":
https://dl.bintray.com/gocd-maven-repo/generic/gocd

This repo is not accessbile anymore, I get a "forbidden".

As version 0.3.6 of this dependency is not at maven central I am not able to build lambdaCD any more.
0.3.6 seems to be a somewhat unofficial version so is there anyone having a valid copy of it?
:/

@flosell
Copy link
Owner

flosell commented May 4, 2021

Hi @hennr - thanks for raising this. I guess this dependency got dropped with Bintray sunsetting...
I also couldn't find any other repository that has it either so I guess the sane thing to do would be to replace this dependency with a different implementation.

Thankfully, it's only used in a single place to kill the whole process tree spawned from a build - In recent JVM versions, this should natively be supported through the ProcessHandle API so hopefully that's not too complex of a change.

I don't have a lot of capacity to work on LambdaCD right now so a PR would be highly appreciated to fix this!

hennr added a commit to hennr/lambdacd that referenced this issue May 6, 2021
@flosell
Copy link
Owner

flosell commented May 9, 2021

Thanks @hennr for providing a fix! It's released as 0.14.6.
I noticed that there was an issue with LambdaUI having its own dependency to an older version of LambdaCD so in case you are using it, quickest fix is to just exclude this dependency as it would be ignored by the build anyway:

:dependencies [[lambdacd "0.14.6"]
               [lambdaui "1.1.0" :exclusions [lambdacd]]
               ; ...
               [org.clojure/clojure "1.9.0"]]

@hennr
Copy link
Contributor Author

hennr commented May 10, 2021

You're welcome and thanks for the hint @flosell!
I had to exclude the lambdacd dependency in some more dependencies like lambdacd-git etc. as well, but now we are back on track.

@tommy-mor
Copy link

I had this problem and fixed it with exclusions for lambdaui and lambdacd-git. thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants