Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make start-pipeline-state-updater or something similar public again to be used by other persistence components #38

Closed
flosell opened this issue Jul 25, 2015 · 3 comments
Closed

Make start-pipeline-state-updater or something similar public again to be used by other persistence components #38

flosell opened this issue Jul 25, 2015 · 3 comments

Comments

@flosell
Copy link
Owner

flosell commented Jul 25, 2015

internal.default-pipeline-state/start-pipeline-state-updater was public until the last release (0560764) and was used by other persistence components, e.g. lambdacd-rest and lambdacd-mongodb.

It looks like their usage of this internal function actually makes sense. Provide a public API for this use case.
@flosell flosell closed this as completed Jul 25, 2015
@flosell flosell reopened this Jul 25, 2015
@flosell
Copy link
Owner Author

flosell commented Jul 25, 2015

Added in 2a0167e

@flosell
Copy link
Owner Author

flosell commented Jul 25, 2015

Components can now use lambdacd.internal.pipeline-state/start-pipeline-state-updater. It'll move to the public namespace once the interface has stabilized

@flosell flosell closed this as completed Jul 25, 2015
flosell added a commit that referenced this issue Aug 1, 2015
@flosell
move pipeline-state-updater out of the responsibility of individual p…
0fbad31 
…ipeline-state component now started by assemble-pipeline (#38, simplifies #40)
@flosell
Copy link
Owner Author

flosell commented Aug 1, 2015

Moved responsibility for start-pipeline-state-updater to assemble-pipeline. Components implementing a the pipeline-state no longer need to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flosell