Add a repo-branch argument to with-git which gets the latest revision…

[kennyjwilli]

… of the given branch and passes it on. This is useful for those using Gitflow because it is more common to checkout the develop branch instead of the master branch.

[flosell]

Thanks for your pull request!

I initially designed this with pipelines in mind that have a wait-for-git step before the with-git. In those cases, wait-for-git would take care of finding the next revision on a branch and with-git is just using the :revision argument from args.

I'm guessing you just want to build the latest commit on a branch. That sounds reasonable to me.

I just have one doubt: Your pull request would introduce a behavior where with-git is normally using the given revision, except if it's being called with three arguments. I'm a bit worried that this isn't exactly intuitive to users.

How about we give put this into a separate function to make it explicit?

I think we can simplify the implementation as well: we don't actually need to find the current-revision since the way checkout-and-execute works, it should also allow a branch as a the revision argument.

Also, if you could add a test for your feature that would be awesome! Prevents me from accidently breaking it :)
This should get you started: https://github.com/flosell/lambdacd/blob/master/test/clj/lambdacd/steps/git_test.clj#L162
If you need help, feel free to reach out.

Last but not least, you don't need to bump the version in project.clj, it's already pointing to the next release.

[kennyjwilli]

Your assumption is correct: I want to build the latest commit from a branch.

Moved and updated the feature to with-git-branch. git checkout does not need a -b argument when checking out a branch, so no changes were made to checkout-and-execute.

What exactly are you looking for in the test? The only thing that could break is the checkout-and-execute function which already has a test, correct?

[flosell]

Looks good!

I would maybe add an additional test that tests your new feature, that it checks out a repository on that branch and calls steps with a :cwd that points to it. Is probably going to look very similar to with-git-test. (I probably should have linked to this one in the first place). (And ignore the TODO on top of that test, thinking about it now I don't think that TODO was a good idea and I'll just get rid of it)

[kennyjwilli]

Yeah that TODO was throwing me off for writing a test case 😕. Added test cases for checking out a specific branch, checking out a repo with an unknown uri, and checking out a repo with a known uri but unknown branch.

[flosell]

All good, merged! Thanks for the contribution. Also, I got rid of that confusing TODO.

[flosell]

Released in version 0.5.3