Remove some incorrect else-if logic in time plugin #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this was mistakenly introduced in a whitespace/bracket cleanup.
|
I have no idea why I made those changes; looking at them now, they make absolutely no sense. Sorry about that, and thanks for finding this, and for the patch! |
ghost
assigned
dnschnur
added a commit
that referenced
this pull request
Apr 20, 2013
Remove some incorrect else-if logic in time plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was some incorrect else-if logic introduced in the time plugin @ f8064ca
Before that commit, our chart looks this: http://d.pr/i/2YXq
Note the crosshair is just before the Feb month tick and the legend says Jan 31 - good.
After that commit, our chart looks like this: http://d.pr/i/lewG
Besides the fact that a new tick was added, the crosshair is again just before the Feb month tick but the legend says Feb 15 - so that's not right.
I corrected the offending change here and now it works again.
This may be related to #1017