Barplot: Specific width for each bar #1261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1416,6 +1417,44 @@ Licensed under the MIT license. | |||
|
|
|||
| var xmin = topSentry, ymin = topSentry, | |||
| xmax = bottomSentry, ymax = bottomSentry; | |||
| var deltaLeft, deltaRight, shiftedVal; | |||
There was a problem hiding this comment.
These should be declared in the function scope that they are used (L1424)
|
I have no idea how to read and fix this Travis CI build error that keeps occurring... |
|
I fixed the build error on the 0.9-work branch so I'm just going to open and close this to get GitHub to recalculate the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding: #25
Regarding the comment posted there:
I'm not sure this is the most elegant approach. But, yes, now the xmin, xmax, ymin and ymax have to be checked for each point. Because any of them can be one of those values with the new dynamic bar width.
Also created an example page, where different plots can be tested out.