Fix bar hovering for charts with bottom points specified #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmgrifter00
approved these changes
Oct 29, 2019
atmgrifter00
added a commit
that referenced
this pull request
Oct 31, 2019
…to interactivity-hooks * 'interactivity-hooks' of https://github.com/flot/flot: (26 commits) 4.0.0 Creating a new major release as we have introduced a change that necessitates the inclusion of a new script to maintain correct behavior. This will replace the previous patch release from 3.2.11 on. This also has a minor bug fix for fixing a hover issue with bar plots. Fix bar hovering for stacked charts (#1697) 3.2.13 Fixing issue #1707, where microsecond formatting wasn't behaving properly. Fixed issue with inconsistent millisecond values on microsecond dates (#1713) 3.2.12 Minor fix to selection plugin to remove unneeded line. Fix selection plugin (#1712) 3.2.11 Fixing issue with selection plugin being used with in conjunction with other plugins using drag events, where we couldn't properly disable the selection plugin drag handlers from the drag handlers of a separate plugin. Update jquery.flot.selection.js (#1705) 3.2.10 Fixing up a local declaration. Update jquery.flot.legend.js (#1699) 3.2.9 Make work for both setData and redo plot Oops - in master Need process data points for when setData is called 3.2.8 Added test and changed how refresh works Fix for hozontal bar spacing Remove initial min distance calculation between first two points Removed f Add test ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is primarily relevant for stacked bar charts. In the current version of flot, if you try to hover on stacked bars, you will only receive hover events for the last series in the data. This is because
findNearbyBardoesn't take into account series with a point size of 3 (where the 3rd point is the bottom of the bar). I used the same pattern fromdrawSeriesBarsto fix this. I also renamed a variable in both places to be closer to its actual meaning.