add labelAlign parameter to axis options to allow naive left/right label... #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... alignment
Yeah, what it said ^.
This came about because users supposedly get confused when e.g. the tick on the first day of March is labeled as "March 2012" instead of the interval itself being marked as such. Here, at least left-aligning the text (i.e. putting the text to the right of the tick) is an ok compromise that implies the area to the right of the tick is "March 2012" without requiring a big logic rewrite to label the intervals rather than the ticks.
Means the border margins are no longer necessarily symmetric, hence the switch to {left:, right:, top:, bottom:}.