Cast tick label to string prior to `replace` call #68

Merged
merged 1 commit into from Jul 29, 2012

Conversation

Projects
None yet
2 participants
Contributor

andromedado commented Jul 27, 2012

In the edge case that an actual integer, or other non-string, is passed as a label, it must be cast to String before replace can safely be called.

Cast tick label to string prior to `replace` call
In the edge case that an actual integer, or other non-string, is passed as a label, it must be cast to String before `replace` can safely be called.

dnschnur added a commit that referenced this pull request Jul 29, 2012

Merge pull request #68 from andromedado/patch-1
Cast tick label to string prior to `replace` call

@dnschnur dnschnur merged commit 36737fd into flot:master Jul 29, 2012

Owner

dnschnur commented Jul 29, 2012

Thanks for catching this!

Contributor

andromedado commented Jul 30, 2012

happy to help. thanks for a great graphing app! (and showing me the more efficient string cast!)

Owner

dnschnur commented Jul 30, 2012

The difference is actually pretty small; I mostly changed it just because
that's what we use elsewhere in the code. Thanks again,

David

On Mon, Jul 30, 2012 at 1:27 PM, Shad Downey <
reply@reply.github.com

wrote:

happy to help. thanks for a great graphing app! (and showing me the more
efficient string cast!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment