Cast tick label to string prior to replace call
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the edge case that an actual integer, or other non-string, is passed as a label, it must be cast to String before `replace` can safely be called.
dnschnur
added a commit
that referenced
this pull request
Jul 29, 2012
Cast tick label to string prior to `replace` call
|
Thanks for catching this! |
|
happy to help. thanks for a great graphing app! (and showing me the more efficient string cast!) |
|
The difference is actually pretty small; I mostly changed it just because David On Mon, Jul 30, 2012 at 1:27 PM, Shad Downey <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edge case that an actual integer, or other non-string, is passed as a label, it must be cast to String before
replacecan safely be called.