Fix setting border color/width as object #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If either color or width is object, normalize the other to object * Only draw each border if its width is greater than 0 * Set strokeStyle and lineWidth _before_ calling ctx.beginPath()
ghost
assigned 
|
I don't mind at all, especially if they're in separate commits like this. I've been doing some cleanup as well, as I start working with new pieces of the codebase, and have plans, once we get 0.8 out the door, to do a complete lint and style-standardization pass. I'll take a look at this and merge it later today; thanks for the submission! |
dnschnur
added a commit
that referenced
this pull request
Nov 27, 2012
Fix setting border color/width as an object.
dnschnur
added a commit
that referenced
this pull request
Nov 27, 2012
|
Woohoo! Thanks so much, @dnschnur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope you don't mind that I did some linting and removed EOL whitespace, too. I put them in separate commits in case you didn't want to merge them in for whatever reason. In any case, the important change here is that I fixed a problem I noticed when trying to set the grid's border width using an object. Let me know if you have any questions.