Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pie plugin: add ability to use given radius #969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bor
Copy link
Contributor

@bor bor commented Feb 21, 2013

radius can be passed in data[i].radius
no impact on existing code (compatible)

would be nice if you accept this commit
it allow us to create another type of chart (based on pie plugin)
with minimal code ;)

for example https://github.com/bor/flot.polar_bar

@bor
Copy link
Contributor Author

bor commented Feb 21, 2013

here you can review examples polar bar plugin (not work as expected yet)
http://bor.github.com/flot.polar_bar/examples/
and how it should look after this commit
http://bor.github.com/flot.polar_bar/examples/example_page.png

@bor bor mentioned this pull request Feb 25, 2013
@dnschnur
Copy link
Member

I like this idea a lot; rose plots are attractive and a natural fit for the pie plugin. I wonder whether adding a new option is the right approach, though. What you really have is two-dimensional data; it seems like it would be more natural to use a second data value instead.

This requires a lot more work, since you need to mess around with the processDatapoints hook, detect when these secondary values are provided, etc. But it feels like a better design, since those values are really part of the data, not a separate option. What do you think?

@bor
Copy link
Contributor Author

bor commented Feb 27, 2013

Yes, it is a good idea too.
I can do this if you don't mind.
But the question is: how it should named? I mean option name(s).

@seanpoulter
Copy link

Have you made any progress @bor?

@dnschnur, have you gave the structure of the data series for these any thought? I've just spent a while thinking about a clean way to balance the data structures to supporting both multi-level pie/stacked wedge graphs and rose/polar area graphs and would like to know what you had in mind before I get too far.

Please do let me know where things are at, otherwise I'll continue updating the supporting functions to work with my quick hack for drawSlice(angle, color, fill) to use a start/end angle and radius to draw slices.

@bor
Copy link
Contributor Author

bor commented Oct 8, 2014

AFAIU the pull request was no merged :(
And at the moment it not compatible with current codebase, so need to review it again.

radius can be passed in data[i].radius
no impact on existing code
@bor
Copy link
Contributor Author

bor commented Oct 8, 2014

Seems like 'rebasing' helps.

@sahilthapar
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants