feat: update plugin to be compatible with Cypress 10. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: updates config for Cypress 10 and updates plugin to use es6 import/exports.
ryanthemanuel
approved these changes
Jul 26, 2022
flotwig
reviewed
Jul 27, 2022
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "name": "cypress-log-to-output", | |||
| "version": "1.1.2", | |||
| "type": "module", | |||
There was a problem hiding this comment.
is this change required for 10.0?
There was a problem hiding this comment.
I think so. I added it so that I could use ES import instead of require.
There was a problem hiding this comment.
Desperately need the v10 support, any chance this can be merged in?
There was a problem hiding this comment.
@flotwig Wanna maybe deprecate in favor of https://github.com/archfz/cypress-terminal-report ?
|
I have found that the plugin still works OK (10.6.0) without any changes UNLESS you have a plugin after it that also adds a listener to before:browser:launch afterwards. Dunno if this is an issue with Cypress or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: updates config for Cypress 10 and updates plugin to use es6 import/exports.
Closes #22