removed empty aws/azure client credentials (#1071)

* fixes #1062 : removed empty aws client credentials and set default region * Removed default values from AWS/Azure streams --------- Co-authored-by: Julien Guittard <julien.guittard@me.com>
flow-php · May 9, 2024 · 45474bb · 45474bb
1 parent a0e4413
commit 45474bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 21 deletions.
diff --git a/src/adapter/etl-adapter-filesystem/src/Flow/ETL/Adapter/Filesystem/AwsS3Stream.php b/src/adapter/etl-adapter-filesystem/src/Flow/ETL/Adapter/Filesystem/AwsS3Stream.php
@@ -37,23 +37,10 @@ protected function filesystem() : Filesystem
              */
             $contextOptions = \stream_context_get_options($this->context);
 
-            /**
-             * @var array{credentials: array{key: string, secret: string}, region: string, version: string} $clientOptions
-             */
-            $clientOptions = \array_merge(
-                [
-                    'credentials' => [
-                        'key' => '',
-                        'secret' => '',
-                    ],
-                    'region' => '',
-                    'version' => 'latest',
-                ],
-                $contextOptions[self::PROTOCOL]['client'] ?? []
-            );
+            $clientOptions = $contextOptions[self::PROTOCOL]['client'];
 
             /** @var string $bucket */
-            $bucket = $contextOptions[self::PROTOCOL]['bucket'] ?? '';
+            $bucket = $contextOptions[self::PROTOCOL]['bucket'];
 
             /**
              * @psalm-suppress PossiblyNullArrayAccess

diff --git a/src/adapter/etl-adapter-filesystem/src/Flow/ETL/Adapter/Filesystem/AzureBlobStream.php b/src/adapter/etl-adapter-filesystem/src/Flow/ETL/Adapter/Filesystem/AzureBlobStream.php
@@ -43,14 +43,10 @@ protected function filesystem() : Filesystem
             /**
              * @var array{connection-string: string} $clientOptions
              */
-            $clientOptions = \array_merge(
-                ['connection-string' => ''],
-                /** @phpstan-ignore-next-line */
-                ['connection-string' => $contextOptions[self::PROTOCOL]['connection-string']] ?? []
-            );
+            $clientOptions = ['connection-string' => $contextOptions[self::PROTOCOL]['connection-string']];
 
             /** @var string $container */
-            $container = $contextOptions[self::PROTOCOL]['container'] ?? '';
+            $container = $contextOptions[self::PROTOCOL]['container'];
 
             /**
              * @psalm-suppress PossiblyNullArrayAccess