Changed default transformers behavior from Entries::add to Entries::s…

…et (#220)
flow-php · Apr 15, 2022 · 80a679f · 80a679f
1 parent 30162e2
commit 80a679f
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 14 deletions.
diff --git a/src/Flow/ETL/Transformer/ArrayCollectionGetTransformer.php b/src/Flow/ETL/Transformer/ArrayCollectionGetTransformer.php
@@ -90,7 +90,7 @@ public function transform(Rows $rows) : Rows
                 throw new RuntimeException("Extracted value from path \"{$path}\" is not array but {$type}");
             }
 
-            return $row->add(
+            return $row->set(
                 new Row\Entry\ArrayEntry(
                     $this->newEntryName,
                     $extractedValues

diff --git a/src/Flow/ETL/Transformer/ArrayCollectionMergeTransformer.php b/src/Flow/ETL/Transformer/ArrayCollectionMergeTransformer.php
@@ -60,7 +60,7 @@ public function transform(Rows $rows) : Rows
             }
 
             /** @psalm-suppress MixedArgument */
-            return $row->add(
+            return $row->set(
                 new Row\Entry\ArrayEntry(
                     $this->newEntryName,
                     /** @phpstan-ignore-next-line  */

diff --git a/src/Flow/ETL/Transformer/ArrayDotGetTransformer.php b/src/Flow/ETL/Transformer/ArrayDotGetTransformer.php
@@ -58,7 +58,7 @@ public function transform(Rows $rows) : Rows
                 throw new RuntimeException("{$this->arrayEntryName} is not ArrayEntry but {$entryClass}");
             }
 
-            return $row->add(
+            return $row->set(
                 $this->entryFactory->create(
                     $this->newEntryName,
                     array_dot_get($arrayEntry->value(), $this->path)

diff --git a/src/Flow/ETL/Transformer/ArrayMergeTransformer.php b/src/Flow/ETL/Transformer/ArrayMergeTransformer.php
@@ -56,7 +56,7 @@ public function transform(Rows $rows) : Rows
                 $entryValues[] = $arrayEntry->value();
             }
 
-            return $row->add(new Row\Entry\ArrayEntry(
+            return $row->set(new Row\Entry\ArrayEntry(
                 $this->newEntryName,
                 \array_merge(...$entryValues)
             ));

diff --git a/src/Flow/ETL/Transformer/HashTransformer.php b/src/Flow/ETL/Transformer/HashTransformer.php
@@ -65,7 +65,7 @@ public function transform(Rows $rows) : Rows
                 }
             }
 
-            return $row->add(Entry::string($this->newEntryName, \hash($this->algorithm, \implode('', $values), false)));
+            return $row->set(Entry::string($this->newEntryName, \hash($this->algorithm, \implode('', $values), false)));
         };
 
         return $rows->map($transformer);

diff --git a/src/Flow/ETL/Transformer/MathOperationTransformer.php b/src/Flow/ETL/Transformer/MathOperationTransformer.php
@@ -112,10 +112,10 @@ public function transform(Rows $rows) : Rows
             };
 
             if (\is_float($value)) {
-                return $row->add(new Row\Entry\FloatEntry($this->newEntryName, $value));
+                return $row->set(new Row\Entry\FloatEntry($this->newEntryName, $value));
             }
 
-            return $row->add(new Row\Entry\IntegerEntry($this->newEntryName, $value));
+            return $row->set(new Row\Entry\IntegerEntry($this->newEntryName, $value));
         };
 
         return $rows->map($transformer);

diff --git a/src/Flow/ETL/Transformer/MathValueOperationTransformer.php b/src/Flow/ETL/Transformer/MathValueOperationTransformer.php
@@ -103,10 +103,10 @@ public function transform(Rows $rows) : Rows
             };
 
             if (\is_float($value)) {
-                return $row->add(new Row\Entry\FloatEntry($this->newEntryName, $value));
+                return $row->set(new Row\Entry\FloatEntry($this->newEntryName, $value));
             }
 
-            return $row->add(new Row\Entry\IntegerEntry($this->newEntryName, $value));
+            return $row->set(new Row\Entry\IntegerEntry($this->newEntryName, $value));
         };
 
         return $rows->map($transformer);

diff --git a/src/Flow/ETL/Transformer/ObjectMethodTransformer.php b/src/Flow/ETL/Transformer/ObjectMethodTransformer.php
@@ -76,7 +76,7 @@ public function transform(Rows $rows) : Rows
                 throw new RuntimeException("\"{$this->objectEntryName}\" is object does not have \"{$this->method}\" method.");
             }
 
-            return $row->add($this->entryFactory->create(
+            return $row->set($this->entryFactory->create(
                 $this->newEntryName,
                 /** @phpstan-ignore-next-line */
                 \call_user_func([$object, $this->method], ...$this->parameters)

diff --git a/src/Flow/ETL/Transformer/ObjectToArrayTransformer.php b/src/Flow/ETL/Transformer/ObjectToArrayTransformer.php
@@ -47,8 +47,7 @@ public function transform(Rows $rows) : Rows
             }
 
             $entries = $row->entries()
-                ->remove($this->objectEntryName)
-                ->add(
+                ->set(
                     new Row\Entry\ArrayEntry(
                         $this->objectEntryName,
                         $this->hydrator->extract(

diff --git a/src/Flow/ETL/Transformer/StaticEntryTransformer.php b/src/Flow/ETL/Transformer/StaticEntryTransformer.php
@@ -36,7 +36,7 @@ public function transform(Rows $rows) : Rows
         /**
          * @psalm-var pure-callable(Row $row) : Row $transformer
          */
-        $transformer = fn (Row $row) : Row => $row->add($this->entry);
+        $transformer = fn (Row $row) : Row => $row->set($this->entry);
 
         return $rows->map($transformer);
     }

diff --git a/src/Flow/ETL/Transformer/StringConcatTransformer.php b/src/Flow/ETL/Transformer/StringConcatTransformer.php
@@ -56,7 +56,7 @@ public function transform(Rows $rows) : Rows
                 $values[] = $entry->toString();
             }
 
-            return $row->add(
+            return $row->set(
                 new Row\Entry\StringEntry(
                     $this->newEntryName,
                     \implode($this->glue, $values)