fixed sims_per_step done bug (#838)

this was causing experiments to end prematurely if sims_per_step > 1
flow-project · Feb 27, 2020 · 4cd30ee · 4cd30ee
1 parent bc65245
commit 4cd30ee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/flow/envs/base.py b/flow/envs/base.py
@@ -395,8 +395,9 @@ def step(self, rl_actions):
 
         # test if the environment should terminate due to a collision or the
         # time horizon being met
-        done = (self.time_counter >= self.env_params.warmup_steps +
-                self.env_params.horizon)  # or crash
+        done = (self.time_counter >= self.env_params.sims_per_step *
+                (self.env_params.warmup_steps + self.env_params.horizon)
+                or crash)
 
         # compute the info for each agent
         infos = {}

diff --git a/flow/envs/multiagent/base.py b/flow/envs/multiagent/base.py
@@ -108,8 +108,8 @@ def step(self, rl_actions):
         states = self.get_state()
         done = {key: key in self.k.vehicle.get_arrived_ids()
                 for key in states.keys()}
-        if crash or (self.time_counter >= self.env_params.warmup_steps +
-                     self.env_params.horizon):
+        if crash or (self.time_counter >= self.env_params.sims_per_step *
+                     (self.env_params.warmup_steps + self.env_params.horizon)):
             done['__all__'] = True
         else:
             done['__all__'] = False