Skip to content

Commit

Permalink
Merge pull request #578 from flow-project/remove_internal_links
Browse files Browse the repository at this point in the history
Remove no_internal_links
  • Loading branch information
AboudyKreidieh committed Jul 23, 2019
2 parents f7c9797 + a9c102d commit 800cbba
Show file tree
Hide file tree
Showing 69 changed files with 114 additions and 224 deletions.
1 change: 0 additions & 1 deletion examples/aimsun/bottlenecks.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ def bottleneck_example(flow_rate, horizon, restart_instance=False,
additional_net_params = {"scaling": SCALING, "speed_limit": 30/3.6}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = InitialConfig(
Expand Down
3 changes: 1 addition & 2 deletions examples/aimsun/grid.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ def grid_example(render=None):
"horizontal_lanes": 1,
"vertical_lanes": 1
}
net_params = NetParams(
no_internal_links=False, additional_params=additional_net_params)
net_params = NetParams(additional_params=additional_net_params)

initial_config = InitialConfig(spacing='custom')

Expand Down
1 change: 0 additions & 1 deletion examples/aimsun/merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def merge_example(render=None):
additional_net_params["pre_merge_length"] = 500
net_params = params.NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = params.InitialConfig()
Expand Down
3 changes: 1 addition & 2 deletions examples/rllab/cooperative_merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ def run_task(*_):
additional_net_params["inner_lanes"] = 1
additional_net_params["outer_lanes"] = 1
additional_net_params["lane_length"] = 75
net_params = NetParams(
no_internal_links=False, additional_params=additional_net_params)
net_params = NetParams(additional_params=additional_net_params)

initial_config = InitialConfig(x0=50, spacing="uniform")

Expand Down
3 changes: 1 addition & 2 deletions examples/rllab/figure_eight.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ def run_task(*_):
"speed_limit": 30,
"resolution": 40
}
net_params = NetParams(
no_internal_links=False, additional_params=additional_net_params)
net_params = NetParams(additional_params=additional_net_params)

initial_config = InitialConfig(spacing="uniform")

Expand Down
4 changes: 1 addition & 3 deletions examples/rllab/green_wave.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def get_flow_params(v_enter, vehs_per_hour, col_num, row_num, add_net_params):

net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=add_net_params)

return initial_config, net_params
Expand Down Expand Up @@ -121,8 +120,7 @@ def get_non_flow_params(enter_speed, add_net_params):
additional_init_params = {'enter_speed': enter_speed}
initial_config = InitialConfig(
spacing='custom', additional_params=additional_init_params)
net_params = NetParams(
no_internal_links=False, additional_params=add_net_params)
net_params = NetParams(additional_params=add_net_params)

return initial_config, net_params

Expand Down
1 change: 0 additions & 1 deletion examples/rllab/stabilizing_highway.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ def run_task(_):
additional_net_params["pre_merge_length"] = 500
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = InitialConfig(
Expand Down
1 change: 0 additions & 1 deletion examples/rllab/velocity_bottleneck.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = InitialConfig(
Expand Down
1 change: 0 additions & 1 deletion examples/rllib/cooperative_merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params={
'ring_radius': 50,
'lane_length': 75,
Expand Down
1 change: 0 additions & 1 deletion examples/rllib/figure_eight.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params=ADDITIONAL_NET_PARAMS.copy(),
),

Expand Down
4 changes: 1 addition & 3 deletions examples/rllib/green_wave.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def get_flow_params(col_num, row_num, additional_net_params):

net = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

return initial, net
Expand Down Expand Up @@ -119,8 +118,7 @@ def get_non_flow_params(enter_speed, add_net_params):
additional_init_params = {'enter_speed': enter_speed}
initial = InitialConfig(
spacing='custom', additional_params=additional_init_params)
net = NetParams(
no_internal_links=False, additional_params=add_net_params)
net = NetParams(additional_params=add_net_params)

return initial, net

Expand Down
1 change: 0 additions & 1 deletion examples/rllib/multiagent_exps/multiagent_figure_eight.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params=deepcopy(ADDITIONAL_NET_PARAMS),
),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ def make_flow_params(n_rows, n_columns, edge_inflow):
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params={
"speed_limit": V_ENTER + 5, # inherited from grid0 benchmark
"grid_array": {
Expand Down
1 change: 0 additions & 1 deletion examples/rllib/stabilizing_highway.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
2 changes: 0 additions & 2 deletions examples/rllib/velocity_bottleneck.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

flow_params = dict(
Expand Down Expand Up @@ -140,7 +139,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
2 changes: 1 addition & 1 deletion examples/sumo/bay_bridge.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def bay_bridge_example(render=None,
departLane="0",
departSpeed=20) # no data for this

net_params = NetParams(inflows=inflow, no_internal_links=False)
net_params = NetParams(inflows=inflow)
net_params.template = TEMPLATE

# download the template from AWS
Expand Down
3 changes: 1 addition & 2 deletions examples/sumo/bay_bridge_toll.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ def bay_bridge_toll_example(render=None, use_traffic_lights=False):
departLane="random",
departSpeed=10)

net_params = NetParams(
inflows=inflow, no_internal_links=False, template=TEMPLATE)
net_params = NetParams(inflows=inflow, template=TEMPLATE)

# download the template from AWS
if use_traffic_lights:
Expand Down
1 change: 0 additions & 1 deletion examples/sumo/bottlenecks.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def bottleneck_example(flow_rate, horizon, restart_instance=False,
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = InitialConfig(
Expand Down
3 changes: 1 addition & 2 deletions examples/sumo/figure_eight.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ def figure_eight_example(render=None):
env_params = EnvParams(additional_params=ADDITIONAL_ENV_PARAMS)

additional_net_params = ADDITIONAL_NET_PARAMS.copy()
net_params = NetParams(
no_internal_links=False, additional_params=additional_net_params)
net_params = NetParams(additional_params=additional_net_params)

scenario = Figure8Scenario(
name="figure8",
Expand Down
4 changes: 1 addition & 3 deletions examples/sumo/grid.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def get_flow_params(col_num, row_num, additional_net_params):

net = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

return initial, net
Expand Down Expand Up @@ -106,8 +105,7 @@ def get_non_flow_params(enter_speed, add_net_params):
additional_init_params = {'enter_speed': enter_speed}
initial = InitialConfig(
spacing='custom', additional_params=additional_init_params)
net = NetParams(
no_internal_links=False, additional_params=add_net_params)
net = NetParams(additional_params=add_net_params)

return initial, net

Expand Down
3 changes: 1 addition & 2 deletions examples/sumo/loop_merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ def loop_merge_example(render=None):
additional_net_params["inner_lanes"] = 1
additional_net_params["outer_lanes"] = 1
additional_net_params["lane_length"] = 75
net_params = NetParams(
no_internal_links=False, additional_params=additional_net_params)
net_params = NetParams(additional_params=additional_net_params)

initial_config = InitialConfig(
x0=50, spacing="uniform", additional_params={"merge_bunching": 0})
Expand Down
1 change: 0 additions & 1 deletion examples/sumo/merge.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ def merge_example(render=None):
additional_net_params["pre_merge_length"] = 500
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

initial_config = InitialConfig(spacing="uniform", perturbation=5.0)
Expand Down
2 changes: 1 addition & 1 deletion examples/sumo/minicity.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def minicity_example(render=None,

env_params = EnvParams(additional_params=ADDITIONAL_ENV_PARAMS)

net_params = NetParams(no_internal_links=False)
net_params = NetParams()

initial_config = InitialConfig(
spacing="random",
Expand Down
2 changes: 0 additions & 2 deletions flow/benchmarks/bottleneck0.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

flow_params = dict(
Expand Down Expand Up @@ -127,7 +126,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
2 changes: 0 additions & 2 deletions flow/benchmarks/bottleneck1.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

flow_params = dict(
Expand Down Expand Up @@ -127,7 +126,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
2 changes: 0 additions & 2 deletions flow/benchmarks/bottleneck2.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
additional_net_params = {"scaling": SCALING, "speed_limit": 23}
net_params = NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params)

flow_params = dict(
Expand Down Expand Up @@ -127,7 +126,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/figureeight0.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params=deepcopy(ADDITIONAL_NET_PARAMS),
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/figureeight1.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params=deepcopy(ADDITIONAL_NET_PARAMS),
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/figureeight2.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
# network-related parameters (see flow.core.params.NetParams and the
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
no_internal_links=False,
additional_params=deepcopy(ADDITIONAL_NET_PARAMS),
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/grid0.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params={
"speed_limit": V_ENTER + 5,
"grid_array": {
Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/grid1.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params={
"speed_limit": V_ENTER + 5,
"grid_array": {
Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/merge0.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/merge1.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down
1 change: 0 additions & 1 deletion flow/benchmarks/merge2.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
# scenario's documentation or ADDITIONAL_NET_PARAMS component)
net=NetParams(
inflows=inflow,
no_internal_links=False,
additional_params=additional_net_params,
),

Expand Down

0 comments on commit 800cbba

Please sign in to comment.