Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #238

Merged
merged 2 commits into from Nov 15, 2018
Merged

Update README.md #238

merged 2 commits into from Nov 15, 2018

Conversation

eugenevinitsky
Copy link
Member

Updated author list on readme

Updated author list on readme
@coveralls
Copy link

coveralls commented Nov 14, 2018

Pull Request Test Coverage Report for Build 1210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.552%

Totals Coverage Status
Change from base Build 1162: 0.0%
Covered Lines: 5067
Relevant Lines: 6619

💛 - Coveralls

Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Fangyu? Unless you actively meant not to, I don't like him either.

@eugenevinitsky
Copy link
Member Author

Yeah I'm not a fan either but I guess we can add him or whatever

Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit e122bd1 into master Nov 15, 2018
@AboudyKreidieh AboudyKreidieh deleted the eugenevinitsky-patch-1 branch November 15, 2018 22:55
crystalzyan pushed a commit to crystalzyan/flow that referenced this pull request Dec 1, 2018
…r issue a warning); increase default number of rollouts (flow-project#238)

## Summary
- compute average return of rollouts
- check that horizon is the same between the experiment horizon and the rendering env horizon (issue a warning if different). The discrepancy is due to the fact that the rendering env horizon is set in the example file, and not from the loaded experiment horizon.
- increase default number of rollouts to 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants