Benchmark regression tests #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanaadp
requested review from
AboudyKreidieh,
cathywu and
eugenevinitsky
as code owners
Pull Request Test Coverage Report for Build 1912
💛 - Coveralls |
| config["eval_prob"] = 0.05 | ||
| config["noise_stdev"] = grid_search([0.01, 0.02]) | ||
| config["stepsize"] = grid_search([0.01, 0.02]) | ||
|
|
||
| config["noise_stdev"] = 0.02 |
There was a problem hiding this comment.
we should set the hp based on the best performing for each benchmark (see paper for details)
flow/benchmarks/rllib/es_runner.py
Outdated
| @@ -60,6 +110,6 @@ | |||
| "max_failures": 999, | |||
| "stop": {"training_iteration": 500}, | |||
| "num_samples": 1, | |||
| "upload_dir": "s3://<BUCKET NAME>" | |||
| "upload_dir": "s3://" + upload_dir | |||
There was a problem hiding this comment.
what if you're not running experiments on aws? this should be defaulted to no uploading there
flow/benchmarks/rllib/ppo_runner.py
Outdated
| @@ -68,6 +112,6 @@ | |||
| "training_iteration": 500 | |||
| }, | |||
| "num_samples": 3, | |||
| "upload_dir": "s3://<BUCKET NAME>" | |||
| "upload_dir": "s3://" + upload_dir | |||
flow/benchmarks/rllib/ppo_runner.py
Outdated
| config["lambda"] = grid_search([0.97, 1.0]) | ||
| config["lr"] = grid_search([5e-4, 5e-5]) | ||
| config["lambda"] = 0.97 | ||
| config["lr"] = 5e-4 |
| @@ -0,0 +1,40 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
nice! can we document this somewhere though? (either a the start of this script or in the benchmarks' README.md)
scripts/benchmark_autoscale.yaml
Outdated
| MarketType: spot | ||
| #Additional options can be found in the boto docs, e.g. | ||
| # SpotOptions: | ||
| # MaxPrice: "1.0" |
There was a problem hiding this comment.
nit: should prob keep this on
flow/benchmarks/rllib/es_runner.py
Outdated
| config["episodes_per_batch"] = N_ROLLOUTS | ||
| config["num_workers"] = N_ROLLOUTS | ||
| config["num_workers"] = min(num_cpus, num_rollouts) | ||
| config["episodes_per_batch"] = num_rollouts | ||
| config["eval_prob"] = 0.05 | ||
| config["noise_stdev"] = grid_search([0.01, 0.02]) |
There was a problem hiding this comment.
specifically, we can remove these duplicate lines?
|
@kanaadp can we move this to the scripts folder and add some documentation to a README? |
|
@kanaadp tests are failing here so we can't merge it |
…flow into benchmark_regression_tests
|
@kanaadp all comments seem addressed; can we merge? |
AboudyKreidieh
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified benchmark run scripts to be more general, added script to run all benchmarks. We still need a script to pull & evaluate trained benchmarks.