Inflows (more features + new tuto) #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanlct
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
…into better-inflows
| @@ -384,6 +384,8 @@ class SimParams(object): | |||
| specifies whether to render the radius of RL observation | |||
| pxpm : int, optional | |||
| specifies rendering resolution (pixel / meter) | |||
| color_vehicles : bool, optional | |||
There was a problem hiding this comment.
really like this feature. it'll definitely be helpful in other cases too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
Link to the tuto notebook: https://github.com/flow-project/flow/blob/better-inflows/tutorials/tutorial12_inflows.ipynb
InFlows.add, and completed the docstring (before there was just a link to sumo's wiki) -- modified the way inflows are created for sumo accordingly -- added some checks to catch easy mistakes with inflow paramsnum_vehicles's default value from 1 to 0 when adding vehicle types inVehicleParams, to make it more explicit that we can have inflows without needed to add initials vehicles to the network (btw when there's no vehicles, numpy raises a mean of empty slice warning, but it doesn't say where it comes from -- maybe create an issue for this?)