Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change flow.networks.loop to ring to fix module error #745

Merged
merged 1 commit into from Oct 2, 2019
Merged

Change flow.networks.loop to ring to fix module error #745

merged 1 commit into from Oct 2, 2019

Conversation

umangs94
Copy link
Contributor

@umangs94 umangs94 commented Oct 2, 2019 •
edited

There is no flow.networks.loop anymore, so this should be changed to flow.networks.ring

@umangs94
Changing loop to ring to fix module error
4dadba3 
There is no flow.networks.loop anywhere, so this should be changed to flow.networks.ring
@umangs94 umangs94 assigned umangs94 and AboudyKreidieh and unassigned umangs94 Oct 2, 2019
eugenevinitsky
eugenevinitsky approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4543

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.914%
Totals Coverage Status
Change from base Build 4528: 0.01%
Covered Lines: 9205
Relevant Lines: 10125
💛 - Coveralls

@umangs94 umangs94 merged commit 0d425fb into master Oct 2, 2019
@umangs94 umangs94 deleted the umangs94-patch-ring branch October 2, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugenevinitsky eugenevinitsky eugenevinitsky approved these changes

@AboudyKreidieh AboudyKreidieh Awaiting requested review from AboudyKreidieh AboudyKreidieh is a code owner

@cathywu cathywu Awaiting requested review from cathywu

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees

@AboudyKreidieh AboudyKreidieh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@umangs94 @coveralls @eugenevinitsky @AboudyKreidieh