Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traffic light grid examples #805

Merged
merged 5 commits into from Jan 9, 2020
Merged

traffic light grid examples #805

merged 5 commits into from Jan 9, 2020

Conversation

ashkan-software
Copy link
Member

@ashkan-software ashkan-software commented Dec 28, 2019 •
edited

Pull request information

Description

Currently, the tests for traffic light grid are simply PASS.
This PR will

  • Add the traffic ligh tests (single agent and multi agent) for traffic light grid examples.
  • Improves the naming of the test examples

This is ready @AboudyKreidieh and @kanaadp. Could you please review this?

@ashkan-software ashkan-software self-assigned this Dec 28, 2019
@ashkan-software ashkan-software changed the title [DO NOT MERGE] traffic light grid examples traffic light grid examples Jan 7, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4985

  • 42 of 42 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.342%
Totals Coverage Status
Change from base Build 4975: 0.2%
Covered Lines: 8671
Relevant Lines: 9598
💛 - Coveralls

AboudyKreidieh
AboudyKreidieh approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus comment

@ashkan-software ashkan-software merged commit 5ceaf08 into master Jan 9, 2020
@ashkan-software ashkan-software deleted the traffic_light_tests branch January 9, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AboudyKreidieh AboudyKreidieh AboudyKreidieh approved these changes

@cathywu cathywu Awaiting requested review from cathywu

@eugenevinitsky eugenevinitsky Awaiting requested review from eugenevinitsky eugenevinitsky is a code owner

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees

@ashkan-software ashkan-software

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashkan-software @coveralls @AboudyKreidieh