Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS syntax support to require-readonly-react-props #54

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

short-dsb
Copy link
Contributor

Per the changelog for 0.229.0, enabling experimental.ts_syntax=true allows some TypeScript syntax, e.g., Readonly versus $ReadOnly.

This PR adds optional support for this syntax to require-readonly-react-props via useExperimentalTypeScriptSyntax.

This is my first PR for this repo, so any feedback is appreciated. 馃檪

Copy link
Member

@Brianzchen Brianzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks good to me

@short-dsb
Copy link
Contributor Author

@Brianzchen I don鈥檛 have write access here. Are you able to merge?

@Brianzchen
Copy link
Member

Yep just wanted to wait in case I recall anything else. Will merge now and cut a release for you

@Brianzchen Brianzchen merged commit 3c8ba41 into flow-typed:master Mar 1, 2024
3 checks passed
@short-dsb short-dsb mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants