Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type defs for jsverify@0.8.x #1403

Merged
merged 1 commit into from Oct 26, 2017
Merged

Add type defs for jsverify@0.8.x #1403

merged 1 commit into from Oct 26, 2017

Conversation

mkscrg
Copy link
Contributor

@mkscrg mkscrg commented Oct 25, 2017

These are translated directly from the TypeScript definitions in jsverify: https://github.com/jsverify/jsverify/blob/master/lib/jsverify.d.ts

gantoine
gantoine requested changes Oct 25, 2017
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you lower the flow version from 0.57.3? Seems the specs ran successfully at 0.34.x, so you might be able to go that low. Having it so high is pretty restrictive.

@gantoine gantoine added the needs updates The PR needs updates before shipping (eg. failing build, bad file path) label Oct 26, 2017
@gantoine gantoine merged commit e7f90c0 into flow-typed:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees
No one assigned
Labels
needs updates The PR needs updates before shipping (eg. failing build, bad file path)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkscrg @gantoine