Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test runner #15

Merged
merged 1 commit into from Mar 17, 2016
Merged

Add a test runner #15

merged 1 commit into from Mar 17, 2016

Conversation

jeffmo
Copy link
Contributor

@jeffmo jeffmo commented Mar 16, 2016

flow-typed run-tests [opt-test-name-pattern]

Running tests means the following:

  1. For each Package/Version/FlowVersion directory, find all versions of Flow that satisfy the specified Flow version
  2. Copy the libdef + all test files into a directory with a .flowconfig specifying a "$ExpectError" suppression comment
  3. Run flow check for each resolved version of Flow on the test directory. If there are any errors, assert them.

This also adds run-tests to the travis command

@jeffmo jeffmo force-pushed the test_runner branch 4 times, most recently from 2fa8f60 to 59923b3 Compare March 16, 2016 18:01
@jeffmo
Copy link
Contributor Author

jeffmo commented Mar 16, 2016

I'm noticing some strange issues in Travis while running Flow (but only sporadically?), so will need to debug those a bit later before this is ready.

The code should be mostly good for review, though

return testGroups;
}

function binSearchArray<T>(arr: Array<T>, testFn: (elem: T) => number): ?T {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this might not be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@mrmurphy
Copy link
Contributor

Looks great @jeffmo! Way to churn out code. I'm 👍 for merging when you're ready and Travis is passing. Did you say there's some code cleanup to do, too?

@jeffmo jeffmo force-pushed the test_runner branch 15 times, most recently from fcbab0a to d669a1c Compare March 17, 2016 15:56
@jeffmo jeffmo merged commit 59706e6 into flow-typed:master Mar 17, 2016
@jeffmo jeffmo deleted the test_runner branch March 17, 2016 16:03
cullophid pushed a commit to cullophid/flow-typed that referenced this pull request Jun 19, 2017
Add syntax highlighting to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants