Add response type to axios libdef #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THis commit adds a separate response type to axios calls, earlier the definitions used the same infered type for config.data and response.data. But hopefully this wont break backwards compatability since I added the original type (T) as default for the new response type (R).
AndrewSouthpaw
requested changes
Mar 29, 2018
| const promise1: AxiosPromise<{ foo: string }, { bar: string }> = axios({ url: '/', method: 'post', data: { foo: 'bar' }}) | ||
| promise1.then(({ data }) => { | ||
| // $ExpectError | ||
| data.foo; |
There was a problem hiding this comment.
Add a check for data.bar is a string, ensure that carries through. :)
gantoine
added
changes requested
|
Thanks for the response (pun intended...)! I added a test to verify that "data.bar" is a string and all tests passes on my machine. |
AndrewSouthpaw
approved these changes
Mar 29, 2018
|
Thanks @adambrgmn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a separate response type to axios calls, earlier the definitions
used the same infered type for config.data and response.data. This has been mentioned in #1975 and #1539.
But hopefully this wont break backwards compatability since I added the
original type (T) as default for the new response type (R). Also verified by tests.
As of now I have only updated the 0.18.x-version. But the same issue is present in earlier versions as well. If you think I should update the old ones as well I'd be happy to do so.