Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 8 args to open-ended redux-saga calls #2751

Merged
merged 2 commits into from Sep 24, 2018

Conversation

dhui
Copy link
Contributor

@dhui dhui commented Sep 23, 2018

Existing libdefs only allow 6 args to redux-saga calls. This PR extends that to 8.

@dhui
Copy link
Contributor Author

dhui commented Sep 23, 2018

Not sure why tests are failing for redux-saga_v0.11.x and redux-saga_v0.13.x when my changes are isolated to redux-saga_v0.16.x

Copy link
Member

@villesau villesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have introduced new lower limit for libdefs. Can you change the previous version folder name to flow_v0.38.x-v0.55.x ?

@dhui
Copy link
Contributor Author

dhui commented Sep 24, 2018

@villesau Thanks for the pointer!
It looks like v0.68.0 is the version of flow where the existing libdefs are broken. I've updated the version folder accordingly and tests are passing now.

@villesau villesau merged commit aba9864 into flow-typed:master Sep 24, 2018
@villesau
Copy link
Member

Nice!

@dhui dhui deleted the redux_saga_8_params branch September 24, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants