Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typedefs for next.js v7 #2839

Merged
merged 1 commit into from Oct 18, 2018
Merged

Add typedefs for next.js v7 #2839

merged 1 commit into from Oct 18, 2018

Conversation

mdowds
Copy link
Contributor

@mdowds mdowds commented Oct 14, 2018

Based on the v4 definitions, with new definitions for the new features added since then.

This is my first PR so let me know if there's anything I've missed!

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean PR, made comparing this with next_v4 super easy!

@gantoine gantoine merged commit 634833e into flow-typed:master Oct 18, 2018
@ussuritiger
Copy link

@mdowds thanks for the typedefs for the Next.js 7. Although after this update I am getting an error while importing getConfig. So

import getConfig from 'next/config';

results into

Cannot resolve module `next/config`.

   1| import getConfig from 'next/config';
                            ^^^^^^^^^^^^^

Any ideas about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants