Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest defs for dom testing library #2849

Merged
merged 1 commit into from Oct 19, 2018
Merged

Conversation

giuband
Copy link
Contributor

@giuband giuband commented Oct 17, 2018

The custom jest matchers for dom-testing-library have been updated in the last few months, here I'm updating their definitions.
Reference: https://github.com/gnapse/jest-dom#custom-matchers

@gantoine
Copy link
Member

Are these all still valid for version 0.23.x, or were they introduced on a later patch?

@gantoine gantoine self-assigned this Oct 19, 2018
@giuband
Copy link
Contributor Author

giuband commented Oct 19, 2018

They would be valid for any jest version, as they are introduced by the external dependency jest-dom. These matchers have been added progressively during the last few months, but their definitions in this file have not been updated.

@gantoine gantoine merged commit b298074 into flow-typed:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants