Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite RxJS 6 types #2855

Merged
merged 5 commits into from Oct 24, 2018
Merged

Rewrite RxJS 6 types #2855

merged 5 commits into from Oct 24, 2018

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Oct 18, 2018

This is a complete rewrite of the RxJS 6.3.3 flow typings. The typings were largely generated from the original typescript definitions using dts-bundle and flowgen.
In addition, the typescript definition test are used to validate the definitions.

Also checkout https://github.com/lgeiger/rxjs-flow for the code used during the development of the typings. These typings are currently used in nteract/nteract#3399 but it would be great to get more feedback from other users.

Closes #2617
Closes #2384
Closes #2356
Closes #2285
Closes #2272

Closes #2637
Closes #2616
Closes #2604

@lgeiger
Copy link
Contributor Author

lgeiger commented Oct 18, 2018

I'm really sorry for the huge diff. I still hope someone dares to check it out 😇

@lgeiger
Copy link
Contributor Author

lgeiger commented Oct 18, 2018

Any ideas why CI fails?

Unexpected file: rxjs_v6.x.x.js. This directory can only contain test files or a libdef file named `rxjs_v6.x.x.js`.

@gantoine
Copy link
Member

@lgeiger One of your files definitions/npm/rxjs_v6.x.x/flow_v0.72.x-/test_zip.ts ends in .ts, it might be tripping it up.

@gantoine gantoine assigned gantoine and unassigned gantoine Oct 19, 2018
@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 24, 2018

How's this now @gantoine?

@lgeiger
Copy link
Contributor Author

lgeiger commented Oct 24, 2018

Once this is merged. I'm happy to also upstream our redux-observable@1.0.0 typings.

@gantoine
Copy link
Member

@villesau @AndrewSouthpaw Would either of you have experience with rxjs defs? These changes are above my understanding 😅

@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 24, 2018

If it helps -- @jayphelps, one of the leads on RxJS, also helped review these changes along with Lukas in a pairing session to get this all set with @nteract. Same goes for the redux-observable typings (which Lukas can introduce in a new PR).

@gantoine
Copy link
Member

Indeed that does help! In that case I'm happy to merge this in. Specs are passing and the formats look good. Great work @lgeiger and others!

@gantoine gantoine merged commit 77d9eda into flow-typed:master Oct 24, 2018
@lgeiger lgeiger deleted the rxjs-rewrite branch October 24, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants