New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite RxJS 6 types #2855
Rewrite RxJS 6 types #2855
Conversation
I'm really sorry for the huge diff. I still hope someone dares to check it out 😇 |
Any ideas why CI fails?
|
@lgeiger One of your files |
How's this now @gantoine? |
Once this is merged. I'm happy to also upstream our |
@villesau @AndrewSouthpaw Would either of you have experience with rxjs defs? These changes are above my understanding 😅 |
If it helps -- @jayphelps, one of the leads on RxJS, also helped review these changes along with Lukas in a pairing session to get this all set with @nteract. Same goes for the redux-observable typings (which Lukas can introduce in a new PR). |
Indeed that does help! In that case I'm happy to merge this in. Specs are passing and the formats look good. Great work @lgeiger and others! |
This is a complete rewrite of the RxJS 6.3.3 flow typings. The typings were largely generated from the original typescript definitions using
dts-bundle
andflowgen
.In addition, the typescript definition test are used to validate the definitions.
Also checkout https://github.com/lgeiger/rxjs-flow for the code used during the development of the typings. These typings are currently used in nteract/nteract#3399 but it would be great to get more feedback from other users.
Closes #2617
Closes #2384
Closes #2356
Closes #2285
Closes #2272
Closes #2637
Closes #2616
Closes #2604