Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-select libdef #3006

Merged
merged 5 commits into from Dec 19, 2018
Merged

Conversation

kangax
Copy link
Contributor

@kangax kangax commented Dec 14, 2018

  • Adds Select.Async
  • Makes Props exact so that they're actually type-safe
  • Fixes faulty autofocus test (as found by exact Props)
  • Defines OptionType in tests the same way as it is defined in react-select
  • Adds a test for an invalid prop

@kangax
Copy link
Contributor Author

kangax commented Dec 14, 2018

@AndrewSouthpaw @villesau @gantoine there are few stylistic changes from the Prettier running in my VSCode. Let me know if I should discard those. On the other hand, it'd be nice to have Prettier running by default in the repo, avoiding any tiny inconsistencies. Was this ever considered?

@gantoine
Copy link
Member

As long as it's running this project's config for prettier they're ok to keep.

@AndrewSouthpaw AndrewSouthpaw merged commit ef77b3d into flow-typed:master Dec 19, 2018
@kangax kangax deleted the react_select_fixes branch December 20, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants