fix qs 6.5.x and add qs 6.9.x #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoganBarnett
force-pushed
the
qs-add-6.9.x
branch
from
6f97a36
to
d057213
Compare
The qs libdefs used the only Function, Object, and sometimes any types - some of which cause issues in newer versions of Flow and/or flow-typed. The old qs 6.5.x tests have had the bare minimum done to get the tests passing again. Most of the work was done against a new (copied) set of libdefs for 6.9.x. I did not know what versions added which arguments, or if certain arguments were omitted on the original 6.5.x, and perusing the documentation for qs did not reveal this in a timely manner. It seemed to make sense make a clean break to 6.9.x. The 6.9.x version of qs should be entirely backwards compatible with 6.5.x, since only new, optional arguments have been added.
|
I am happy to appease the lintings we have re: |
|
Hm. Does running |
|
|
|
@AndrewSouthpaw fixed! |
This was referenced Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
The
qslibdefs used the onlyFunction,Object, and sometimesanytypes - some of which cause issues in newer versions of Flow and/or flow-typed. The oldqs6.5.x tests have had the bare minimum done to get the tests passing again. Most of the work was done against a new (copied) set of libdefs for 6.9.x. I did not know what versions added which arguments, or if certain arguments were omitted on the original 6.5.x, and perusing the documentation forqsdid not reveal this in a timely manner. It seemed to make sense make a clean break to 6.9.x. The 6.9.xversion of
qsshould be entirely backwards compatible with 6.5.x, since only new, optional arguments have been added.