add $ReadOnlyArray support to ramda includes + contains #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramda's includes (same as contains, but contains is deprecated), would not respect $ReadOnlyArray. These changes allow for $ReadOnlyArray and also enforce a strict case when it comes to using strings (only strings may be compared with strings). Tests have been added to enforce this behavior. Some tests have been problematic to enforce - namely the all-arity version of $ReadOnlyArray. It is not well understood why this is happening, but there are comments noting the expected outcome vs. actual. I don't believe it's a covariance issue, because 1) the curried form works fine, and 2) string and number shouldn't be covariant. I also took the liberty of sorting some of the import lists, because it's very easy to find/place things when it's alphabetized :)
AndrewSouthpaw
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
Ramda's
includes(same ascontains, butcontainsis deprecated), would not respect$ReadOnlyArray. These changes allow for$ReadOnlyArrayand also enforce a strict case when it comes to using strings (only strings may be compared with strings). Tests have been added to enforce this behavior.Some tests have been problematic to enforce - namely the all-arity version of
$ReadOnlyArray. It is not well understood why this is happening, but there are comments noting the expected outcome vs. actual. I don't believe it's a covariance issue, because 1) the curried form works fine, and 2)stringandnumbershouldn't be covariant.I also took the liberty of sorting some of the import lists, because it's very easy to find/place things when it's alphabetized :)