Fix GH_CLIENT usage in runTests test #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getReleases` method was renamed to `listReleases` in version 16 of
the @octokit/rest package [0]. flow-typed upgraded from 15.12.1 to 16.33.1
in recently [1] and that's when the bug was probably introduced.
The bug is not triggered in Travis CI because:
1. the flow binaries are probably all cached and you don't need to
download them
2. the code that downloads them is in a try/catch block. If the
download fails, the tests default to using the cached binaries. This
works for people who have run the tests before, but not for
newcomers like me.
[0]: https://github.com/octokit/rest.js/releases/tag/v16.0.1 (first item
of breaking changes)
[1]: fed266b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
The
getReleasesmethod was renamed tolistReleasesin version 16 ofthe @octokit/rest package (https://github.com/octokit/rest.js/releases/tag/v16.0.1 first item
of breaking changes). flow-typed upgraded from 15.12.1 to 16.33.1
in recently and that's when the bug was probably introduced.
The bug is not triggered in Travis CI because:
download them
download fails, the tests default to using the cached binaries. This
works for people who have run the tests before, but not for
newcomers like me.