Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@reach/router added state to DomLocation and Redirect props #3647

Merged
merged 1 commit into from
Nov 28, 2019
Merged

@reach/router added state to DomLocation and Redirect props #3647

merged 1 commit into from
Nov 28, 2019

Conversation

Allaoua9
Copy link
Contributor

Other notes:
#3646

@Allaoua9
Copy link
Contributor Author

Can anyone tell me why i'm getting errors on LinkProps although my changes dont affect this type ?

@Allaoua9
Copy link
Contributor Author

Can anyone tell me why i'm getting errors on LinkProps although my changes dont affect this type ?

Even adding a comment to the type def file raises the same error 😕

pascalduez
pascalduez approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@pascalduez pascalduez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests already on master, probably because of recent changes in spreads.
Would be nice to get a fix.

@pascalduez pascalduez merged commit 29009cc into flow-typed:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalduez pascalduez pascalduez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Allaoua9 @pascalduez