Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions for @skbkontur/react-ui #3657

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Add type definitions for @skbkontur/react-ui #3657

merged 4 commits into from
Jan 6, 2020

Conversation

Eazymov
Copy link
Contributor

@Eazymov Eazymov commented Dec 1, 2019

@Eazymov Eazymov mentioned this pull request Dec 2, 2019
Closed
37 tasks
AndrewSouthpaw
AndrewSouthpaw reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@AndrewSouthpaw AndrewSouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a fork of the official react-ui repo? Any reason it needs to be published here?

@Eazymov
Copy link
Contributor Author

Eazymov commented Dec 11, 2019

We are removing flow typings from the @skbkontur/react-ui package and want to publish it via flow-typed

@wKich
Copy link

wKich commented Dec 25, 2019

@AndrewSouthpaw, we will remove flow typings in the next major release, so we need to publish it as flow-typed before.

@AndrewSouthpaw AndrewSouthpaw merged commit c53bc64 into flow-typed:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSouthpaw AndrewSouthpaw AndrewSouthpaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eazymov @wKich @AndrewSouthpaw