Make history interface compatible with react-router #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to documentation:
https://github.com/ReactTraining/history/tree/master/docs
https://github.com/ReactTraining/react-router/tree/master/packages/react-router/docs/api
Type of contribution: fix
Other notes:
Should fix #1910.
Making
MemoryHistory.canGooptional is actually wrong, but I don't see another way to work around flow bugs.All
history/*modules can be probably moved tohistory, it would reduce duplication. But I addedhistoryanyway becase normally everything is exported fromhistory.Properties I removed from
react-router-*don't belong to the generic Location interface.