Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack_v4.x.x] Fix type error #3701

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented Jan 15, 2020

Other notes:

Error --------------------------------------------------------------------------------------- src/utils/buildJs.js:42:26
 

Cannot call `stats.toString` with object literal bound to `options` because object type [1] is incompatible with
 boolean [2] in property `colors`.

    src/utils/buildJs.js:42:26
    42|       log(stats.toString({ logStats, colors: true }));
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
 References:
    ../../flow-typed/npm/webpack_v4.x.x.js:399:9
                 v
   399|       | {
   400|       bold?: string,
   401|       cyan?: string,
   402|       green?: string,
   403|       magenta?: string,
   404|       red?: string,
   405|       yellow?: string,
   406|       ...
   407|     },
            ^ [1]
   ../../flow-typed/npm/webpack_v4.x.x.js:20:50
    20|     toString(options?: StatsOptions & { colors?: boolean, ... }): string;
                                                         ^^^^^^^ [2]

Copy link
Contributor

@AndrewSouthpaw AndrewSouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndrewSouthpaw AndrewSouthpaw merged commit 7448070 into flow-typed:master Jan 16, 2020
@HsuTing HsuTing deleted the fix-webpack branch January 17, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants