[@testing-library/react_v8.x.x] and [@testing-library/react_v9.x.x]: Fix typing regression #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valscion
changed the title
valscion
force-pushed
the
fix-testing-library-react-types
branch
from
e9b944e
to
d797657
Compare
|
Re-pushed my last commit as the CI got stuck last time: https://travis-ci.org/flow-typed/flow-typed/jobs/638417425 EDIT: Oh, that didn't trigger a re-run in CI. Does the good old classic close+reopen work? |
valscion
commented
Jan 17, 2020
| container?: HTMLElement, | ||
| baseElement?: HTMLElement, | ||
| hydrate?: boolean, | ||
| queries?: Q, | ||
| queries?: any, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
Fixes #3520, that is,
@testing-library/reacttypes being broken ever since #3510 was merged in.The first commit in this PR shows how the existing types are broken.