Update query-string 6.x definitions #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some definitions that were missing for the latest version of [`query-string`](https://github.com/sindresorhus/query-string#stringifyobject-options). See flow-typed#3693.
pascalduez
reviewed
Jan 17, 2020
definitions/npm/query-string_v6.x.x/flow_v0.104.x-/query-string_v6.x.x.js
Outdated
Show resolved
Hide resolved
pascalduez
approved these changes
Jan 18, 2020
|
Would be rad if someone could have a look at the failing tests, looks like there's a wrong assertion... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
query-string_v6.x.x.jsdefinitions with latest options and methods that were missing.I updated the tests as well as I could, hope that's sufficient.
closes #3693