Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash: differenceBy/differenceWith update #3707

Merged
merged 5 commits into from
Jan 27, 2020

Conversation

lukeapage
Copy link
Contributor

Other notes:

when using differenceBy and differenceWith the types of the "values" and array do not need to match e.g.

_.differenceBy([{ id: 1, a: 2 }], [{ id: 1 }], ({ id }) => id);

In fact if using the by or with alternatives I would argue they are more likely to not match.

@valscion
Copy link
Contributor

This seems to break the lodash tests. Would you be so kind to debug why the tests fail and maybe add a new test case to demonstrate why this change is needed?

@lukeapage
Copy link
Contributor Author

@valscion the failures are on a part of the definition I didn't touch. I'm fairly sure its due to a new flow version that doesn't like part of the tests. I will try and send a pr to fix it and add a test to this one.

@lukeapage
Copy link
Contributor Author

I merged the fix here but i suggest you merge #3714 first

@valscion
Copy link
Contributor

Cool, thanks! This looks more ready to me now, and as the CI is green, this has a better chance of getting merged ☺️

@gantoine gantoine merged commit ae5262d into flow-typed:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants