[@testing-library/react_v9.x.x] refactor: Clean up the types #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the same unused import from all react-testing-library versions (the previous name of the library). This unused import seems to have been there from the beginning: 14a28a0
valscion
commented
Jan 27, 2020
| |} & Queries; | ||
| declare type RenderResultWithCustomQueries<CustomQueries> = { | ||
| ...CustomQueries, | ||
| declare type RenderResult<Queries = GetsAndQueries> = { |
There was a problem hiding this comment.
Now this type is no longer exact (as I can't think of a way to specify that Queries could be exact). Maybe this is still better than having two different types for the render result as we did after #3705.
There was a problem hiding this comment.
Not 100% sure that spreading inexact objects is a good thing, but definitely better than an intersection on an exact one :) Plus less type duplication. Let's try.
pascalduez
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
Following up from #3705, this PR cleans up the existing
@testing-library/react_v9.x.xtypes so that there are less confusing parts.At any point of this PR, this is ready to be merged. When reviewers have time, I will be happy to get this PR merged and then can continue future work on these types in another PR☺️