Upgrade CLI dependencies #3743
Upgrade CLI dependencies #3743
Conversation
|
@moroine Amazing! 馃帀 Let me check in with folks to make sure the bump to node >= 10 is acceptable. |
|
Also there's a few CLI tests that are still failing, and they can be reproduced locally with running |
cli/src/commands/install.js
Outdated
| flowVersion: { | ||
| alias: 'f', | ||
| describe: | ||
| 'The Flow version that fetched libdefs must be compatible ' + 'with', |
There was a problem hiding this comment.
I know it was already there but wondering about the concatenation... Can't see any use.
cli/src/lib/npm/npmLibDefs.js
Outdated
| @@ -70,11 +70,11 @@ async function extractLibDefsFromNpmPkgDir( | |||
| const pkgDirItems = await fs.readdir(pkgDirPath); | |||
|
|
|||
| if (validating) { | |||
| const fullPkgName = `${scope === null ? '' : scope + '/'}${pkgName}`; | |||
| const fullPkgName = `${scope === null ? '' : scope + '/'}${pkgName}popopko`; | |||
There was a problem hiding this comment.
You might want to remove this? :)
cli/src/lib/npm/npmLibDefs.js
Outdated
| @@ -88,8 +88,9 @@ async function extractLibDefsFromNpmPkgDir( | |||
| }) | |||
| .then() | |||
| .catch(error => { | |||
| console.log(error); | |||
|
@moroine Really nice, thanks! About the node >= 10 bump, it's okay if we release this as a major version I guess. |
| @@ -13,48 +13,49 @@ | |||
| "version": "2.6.2", | |||
| "main": "dist/cli.js", | |||
| "bin": "dist/cli.js", | |||
| "engines": { | |||
| "node": ">=10.0.0" | |||
| }, | |||
There was a problem hiding this comment.
Good timing on this change (now that Node 8 is no longer maintained)
@AndrewSouthpaw test failing in NodeJS 12 is due to change in NodeJS 11 when switching to a stable algorithm. I've made the fix to have a deterministic order (ignoring prerelease). |
|
Great work @moroine ! Merging. |
|
@gantoine You'll probably need to bump the flow-typed version. |
|
@AndrewSouthpaw On it, I'll get one out tonight. |
Minor deps upgrades:
@octokit/rest:16.33.1~>16.43.1colors:1.3.2~>1.4.0flowgen:1.9.0~>1.10.0glob:7.1.3~>7.1.3prettier:1.18.2~>1.19.1table:5.0.2~>5.4.6Major deps upgrades:
fs-extra:7.0.0~>8.1.0got:8.3.2~>10.5.7mkdirp:0.5.1~>1.0.3rimraf:2.6.2~>3.0.2semver:5.5.1~>7.1.3unzipper:0.9.3~>0.10.8which:1.3.1~>2.0.2yargs:12.0.2~>15.1.0Removed deps:
@babel/polyfill: not needed any more thanks to dropping end-of-life Node versionsDev-deps upgrades:
@babel/cli:7.1.0~>7.8.4@babel/core:7.1.0~>7.8.4@babel/preset-env:7.1.0~>7.8.4@babel/preset-flow:7.1.0~>7.8.4babel-core: removedbabel-eslint:10.0.1~>10.0.3babel-jest:23.6.0~>25.1.0eslint:5.6.0~>6.8.0eslint-plugin-flowtype:2.50.3~>4.6.0eslint-plugin-prettier:2.7.0~>3.1.2flow-bin:0.81.0~>0.118.0馃殌jest:23.6.0~>25.1.0CI:
exit 0to return error code on failed testMisc:
@octokit/restdeprecation messageFlow Defs:
mkdirp_v1.0.xwill need to be added later in definitions (will do a separated PR)yargs_v15.0.xhas been created by copy/pasteyargs_v12.0.xthis should be alright as API didn't change much but would require a proper PR.Breaking Change: