refactor: clean up fs.readFile usage #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards1211
changed the title
|
is this related to #3965 ? |
|
@AndrewSouthpaw it doesn't fix that issue AFAIK. I just noticed the weird fs calls while reporting that issue, and figured why not make them more normal. |
pascalduez
approved these changes
Dec 8, 2020
AndrewSouthpaw
approved these changes
Dec 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
fs.readFilewas being used looked like a code smell, and sure enough, the way it was being mocked would cause surprise errors for anyone who adds idiomaticfs-extracalls in new or updated tests. Pass encoding ('utf8', the default) to getreadFileto resolve to a string instead of a buffer, and usereadJsonwhere applicable. Update fs mocks to behave a bit more likefs-extrain this regard (though I'm not sure it would be possible to support all options, but we can at least support encoding string as second argument).