-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create def script for easier lib def creation #4125
Conversation
@FezVrasta not exactly what you were asking for but what do you think? Should remove a lot of small mistakes with repetition when creating a new lib def |
Could/should this be a command instead of a bash file? That way we can add it to the docs and help menu. |
Sorry @gantoine what do you mean? Do you want this to be a node command that lives in |
Yeah exactly! In the same way you'd run |
@gantoine Made a change, let me know if it's what you're looking for. Learnt more about the cli so that was good experience :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. @Brianzchen looks like maybe you didn't push the latest changes turning it into a CLI command?
Create a handy script inspired from #4042 that will create a basic structure for new type def configured to an appropriate lowest supported version as recommended in contribution guide.
Comes built with a lib def file plus a test file with base structure
Usage:
./create_def.sh lib-name 1.x.x
Skeleton File/Folder Structure
sample when running
./create_def.sh test 1.x.x
Script Error Handling