Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-router-dom] update Route component type (complete) #4418

Conversation

iamdey
Copy link
Contributor

@iamdey iamdey commented Jan 31, 2023

Other notes:

I've provided two versions in order to improve react-router-dom's Route Props

This PR:

  • Add missing props to Route component.
  • Import types from source code then adapt to flow.
  • update and fix Route component tests according to the changes

This PR is more complete and should provides more precise types but it's not yet fully tested

- Add missing props to Route component.
- Import types from source code then adapt to flow.
- update and fix Route component tests according to the changes.
@iamdey iamdey changed the title [react-router-dom] update Route component type [react-router-dom] update Route component type (complete) Jan 31, 2023
@Brianzchen Brianzchen merged commit d2cf939 into flow-typed:master Feb 6, 2023
@iamdey iamdey deleted the react-router-dom/update_route_component_type_A branch February 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants