-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libdef for openai-node v3.3.0 #4459
Conversation
Thanks, geez my bad it's meant to be this https://www.npmjs.com/package/tua-body-scroll-lock. Will look into it tonight and get back to you |
Also this is quite a humongous definition file. Do you think more tests would be helpful? Or is the part you've tested all you need for it to be considered secure? |
Pull from |
It is covering the most common use-case of the library, which is pretty simple. (It's also the only case that I'm using.)
Ok, I'll add a test case covering another piece of the library and pull from main. |
@Brianzchen thanks for your review. This PR is updated now and has passing tests. |
Thanks I’ll do some sanity check tonight 🤞 |
Looks fine overall. Just one question, did you want to make the def |
Ok, that sounds good. I'll push a change to 3.x.x. |
@Brianzchen thanks; I pushed c2221f1 renaming with more general versioning v3.x.x. |
Other notes: