[webpack] Add ProgressPlugin #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
approved these changes
Oct 11, 2023
pascalduez
approved these changes
Oct 11, 2023
| @@ -10,6 +10,29 @@ declare module 'webpack' { | |||
|
|
|||
| declare type WebpackError = $WebpackError; | |||
|
|
|||
| declare type WebpackLogger = {| | |||
| getChildLogger: (arg0: string | (() => string)) => WebpackLogger, | |||
| error(...args: any[]): void, | |||
There was a problem hiding this comment.
I thinks spread params should rather use $ReadOnlyArray, but probably not big deal here.
There was a problem hiding this comment.
Great tip! Will start using this going forward
| | ProgressHandler; | ||
|
|
||
| declare class ProgressPlugin { | ||
| constructor(options?: ProgressPluginArgument): $ElementType< |
There was a problem hiding this comment.
$ElementType, $PropertyType are deprecated, but this would force to clone/scope to >0.155 that libdef.
Maybe there will be a codemod pass for this one day.
There was a problem hiding this comment.
All other plugins had the same syntax so I just followed. Have fixed them now across the definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4528
Other notes: