[@tanstack/react-query] Adding definition #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brianzchen
requested changes
Dec 14, 2023
definitions/npm/@tanstack/react-query_v5.x.x/flow_v0.83.x-/react-query_v5.x.x.js
Outdated
Show resolved
Hide resolved
definitions/npm/@tanstack/react-query_v5.x.x/flow_v0.83.x-/test_react-query_v5.x.x.js
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| test('UseMutationOptions', () => { |
There was a problem hiding this comment.
Suggested change
| test('UseMutationOptions', () => { | |
| test('useMutation', () => { |
| const queryClient = 'new QueryClient()'; | ||
| <QueryClientProvider client={queryClient}>{/* Your component */}</QueryClientProvider>; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Can you add another small test that tries to import a function that currently isn't typed so that we can ensure that even if we haven't typed it people can still use it
|
|
||
| test('QueryClientProvider', () => { | ||
| // Correct usage, but not as string. Need to import QueryClient from @tanstack/react-query | ||
| const queryClient = 'new QueryClient()'; |
| test('QueryClientProvider', () => { | ||
| // Correct usage, but not as string. Need to import QueryClient from @tanstack/react-query | ||
| const queryClient = 'new QueryClient()'; | ||
| <QueryClientProvider client={queryClient}>{/* Your component */}</QueryClientProvider>; |
There was a problem hiding this comment.
Maybe try passing a div so that we can prove it takes react children correctly
Suggested change
| <QueryClientProvider client={queryClient}>{/* Your component */}</QueryClientProvider>; | |
| <QueryClientProvider client={queryClient}><div /></QueryClientProvider>; |
yarn.lock
Outdated
Brianzchen
reviewed
Dec 15, 2023
| useQueryErrorResetBoundary: any, | ||
| focusManager: any, | ||
| onlineManager: any, | ||
| hydration: any, |
There was a problem hiding this comment.
I think you need to go through the docs and see what's exposed. I can see for example HydrationBoundary that is missing
Brianzchen
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes: